Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

@alicejli
Copy link
Contributor

@alicejli alicejli commented Aug 31, 2022

Fixes #971, #972 ☕️

My best guess is that "Shakespeare" recently got added into a dictionary this API uses as a "PERSON_NAME", so the test needed to be updated. I confirmed this by testing on the API explorer here: https://cloud.google.com/dlp/docs/reference/rest/v2/projects.content/deidentify

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: dlp Issues related to the googleapis/java-dlp API. labels Aug 31, 2022
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2022
@alicejli alicejli closed this Aug 31, 2022
@alicejli alicejli reopened this Aug 31, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 31, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
renovate-bot and others added 2 commits September 1, 2022 10:13
…1.1 (#975) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4NC4yIn0=-->
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@alicejli alicejli marked this pull request as ready for review September 1, 2022 15:47
@alicejli alicejli requested a review from a team as a code owner September 1, 2022 15:47
@alicejli alicejli merged commit 38a3636 into main Sep 1, 2022
@alicejli alicejli deleted the updateSampleTests branch September 1, 2022 16:06
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2022
🤖 I have created a release *beep* *boop* --- ## [3.7.0](v3.6.7...v3.7.0) (2022-09-15) ### Features * Add Deidentify action ([#977](#977)) ([cd0271d](cd0271d)) ### Bug Fixes * Update DeIdentificationTest ([#976](#976)) ([38a3636](38a3636)) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](#960)) ([2b588be](2b588be)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](#969)) ([d944dbf](d944dbf)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](#974)) ([958c2de](958c2de)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](#982)) ([72292a6](72292a6)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](#980)) ([efb18ab](efb18ab)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](#984)) ([2aeeea3](2aeeea3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request Sep 17, 2022
🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/java-dlp@v3.6.7...v3.7.0) (2022-09-15) ### Features * Add Deidentify action ([#977](googleapis/java-dlp#977)) ([4f43cd5](googleapis/java-dlp@4f43cd5)) ### Bug Fixes * Update DeIdentificationTest ([#976](googleapis/java-dlp#976)) ([661f316](googleapis/java-dlp@661f316)) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](googleapis/java-dlp#960)) ([c66384d](googleapis/java-dlp@c66384d)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](googleapis/java-dlp#969)) ([586795f](googleapis/java-dlp@586795f)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](googleapis/java-dlp#974)) ([b37407b](googleapis/java-dlp@b37407b)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](googleapis/java-dlp#982)) ([8ac525a](googleapis/java-dlp@8ac525a)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](googleapis/java-dlp#980)) ([885dc15](googleapis/java-dlp@885dc15)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](googleapis/java-dlp#984)) ([8cd0a40](googleapis/java-dlp@8cd0a40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sita04 pushed a commit to GoogleCloudPlatform/java-docs-samples that referenced this pull request Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/java-dlp@v3.6.7...v3.7.0) (2022-09-15) ### Features * Add Deidentify action ([#977](googleapis/java-dlp#977)) ([cd0271d](googleapis/java-dlp@cd0271d)) ### Bug Fixes * Update DeIdentificationTest ([#976](googleapis/java-dlp#976)) ([38a3636](googleapis/java-dlp@38a3636)) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](googleapis/java-dlp#960)) ([2b588be](googleapis/java-dlp@2b588be)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](googleapis/java-dlp#969)) ([d944dbf](googleapis/java-dlp@d944dbf)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](googleapis/java-dlp#974)) ([958c2de](googleapis/java-dlp@958c2de)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](googleapis/java-dlp#982)) ([72292a6](googleapis/java-dlp@72292a6)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](googleapis/java-dlp#980)) ([efb18ab](googleapis/java-dlp@efb18ab)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](googleapis/java-dlp#984)) ([2aeeea3](googleapis/java-dlp@2aeeea3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dlp Issues related to the googleapis/java-dlp API. size: s Pull request size is small.

4 participants