Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

feat: add v2 client #423

Merged
merged 8 commits into from
Sep 14, 2022
Merged

feat: add v2 client #423

merged 8 commits into from
Sep 14, 2022

Conversation

@meltsufin
Copy link
Member

@meltsufin meltsufin commented Sep 12, 2022 •
edited
Loading

The commit are broken down to make it clear which parts are autogenerated and which parts had to be manually edited.
@meltsufin meltsufin requested a review from a team as a code owner September 12, 2022 18:00
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: iam Issues related to the googleapis/java-iam API. labels Sep 12, 2022
@meltsufin meltsufin requested a review from suztomo September 12, 2022 18:00
@meltsufin meltsufin mentioned this pull request Sep 12, 2022
Closed
@googleapis googleapis deleted a comment from generated-files-bot bot Sep 12, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Sep 12, 2022

Warning: This pull request is touching the following templated files:

  • .github/CODEOWNERS
@suztomo
Copy link
Member

suztomo commented Sep 12, 2022

CLIRR is failing with removed classes. "beta" marked version is ok to have breaking changes. Would you confirm this intentional? (The CL messages would reveal that)

[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ proto-google-iam-v2beta --- [INFO] artifact com.google.api.grpc:proto-google-iam-v2beta: checking for updates from central [INFO] Comparing to version: 1.5.2 Error: 8001: com.google.iam.v2beta.PolicyName: Class com.google.iam.v2beta.PolicyName removed Error: 8001: com.google.iam.v2beta.PolicyName$Builder: Class com.google.iam.v2beta.PolicyName$Builder removed
@meltsufin
Copy link
Member Author

meltsufin commented Sep 13, 2022

CLIRR is failing with removed classes. "beta" marked version is ok to have breaking changes. Would you confirm this intentional? (The CL messages would reveal that)

[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ proto-google-iam-v2beta --- [INFO] artifact com.google.api.grpc:proto-google-iam-v2beta: checking for updates from central [INFO] Comparing to version: 1.5.2 Error: 8001: com.google.iam.v2beta.PolicyName: Class com.google.iam.v2beta.PolicyName removed Error: 8001: com.google.iam.v2beta.PolicyName$Builder: Class com.google.iam.v2beta.PolicyName$Builder removed

It's not a new failure. You can see the same in main branch: https://github.com/googleapis/java-iam/actions/runs/3026401708/jobs/4869759373.
@suztomo
Copy link
Member

suztomo commented Sep 13, 2022

Thank you for checking. ci / dependencies (8) failed.

[INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ proto-google-iam-v2beta --- Warning: Unused declared dependencies found: Warning: com.google.api.grpc:proto-google-iam-v1:jar:1.5.3-SNAPSHOT:compile Warning: com.google.api:api-common:jar:2.2.1:compile Warning: com.google.guava:guava:jar:31.1-jre:compile
suztomo
suztomo approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get the checks green.
proto-google-iam-v2beta/pom.xml Outdated
Comment on lines 24 to 35
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v1</artifactId>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>api-common</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
Copy link
Member

@suztomo suztomo Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong module?

[INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ proto-google-iam-v2beta --- Warning: Unused declared dependencies found: Warning: com.google.api.grpc:proto-google-iam-v1:jar:1.5.3-SNAPSHOT:compile Warning: com.google.api:api-common:jar:2.2.1:compile Warning: com.google.guava:guava:jar:31.1-jre:compile
Copy link
Member Author

@meltsufin meltsufin Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't notice that! Thanks!
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Sep 14, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6b6c24f into main Sep 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-v2 branch September 14, 2022 02:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2022
@release-please release-please bot mentioned this pull request Sep 14, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: iam Issues related to the googleapis/java-iam API. size: xl Pull request size is extra large.

2 participants

@meltsufin @suztomo