Skip to content

feat: add PostgreSQLEngine #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 9, 2024
Merged

feat: add PostgreSQLEngine #13

merged 15 commits into from
Feb 9, 2024

Conversation

@averikitsch
Copy link
Collaborator

@averikitsch averikitsch commented Feb 9, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@averikitsch averikitsch requested a review from a team as a code owner February 9, 2024 18:56
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Feb 9, 2024
@averikitsch averikitsch requested a review from kurtisvg February 9, 2024 19:04
kurtisvg
kurtisvg requested changes Feb 9, 2024
View reviewed changes
averikitsch and others added 8 commits February 9, 2024 13:22
@averikitsch @kurtisvg
Update src/langchain_google_cloud_sql_pg/postgresql_engine.py
58770b1 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@averikitsch @kurtisvg
Update src/langchain_google_cloud_sql_pg/postgresql_engine.py
03564df 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@averikitsch @kurtisvg
Update src/langchain_google_cloud_sql_pg/postgresql_engine.py
37a2a1e 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@averikitsch @kurtisvg
Update src/langchain_google_cloud_sql_pg/postgresql_engine.py
aed45b1 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@averikitsch @kurtisvg
Update src/langchain_google_cloud_sql_pg/postgresql_engine.py
a49a239 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@averikitsch
add json column
2c258cb
@averikitsch
Update comments
590ce5e
@averikitsch
fix
199a7e7
@averikitsch averikitsch requested a review from kurtisvg February 9, 2024 21:59
kurtisvg
kurtisvg approved these changes Feb 9, 2024
View reviewed changes
pyproject.toml Outdated

[tool.mypy]
python_version = 3.8
python_version = "3.11"
Copy link
Collaborator

@kurtisvg kurtisvg Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?
@averikitsch averikitsch merged commit b181f65 into main Feb 9, 2024
@averikitsch averikitsch deleted the akitsch-engine branch February 9, 2024 23:50
@release-please release-please bot mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

2 participants

@averikitsch @kurtisvg