Skip to content

feat(ci): test against multiple versions #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2024
Merged

feat(ci): test against multiple versions #86

merged 4 commits into from
Mar 15, 2024

Conversation

@averikitsch
Copy link
Collaborator

@averikitsch averikitsch commented Mar 13, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@averikitsch averikitsch requested a review from a team as a code owner March 13, 2024 21:02
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Mar 13, 2024
@averikitsch averikitsch requested a review from kurtisvg March 13, 2024 21:19
kurtisvg
kurtisvg approved these changes Mar 14, 2024
View reviewed changes
.github/sync-repo-settings.yaml
- "pg-integration-test-pr-py38 (langchain-cloud-sql-testing)"
- "pg-integration-test-pr-py39 (langchain-cloud-sql-testing)"
- "pg-integration-test-pr-py310 (langchain-cloud-sql-testing)"
- "pg-integration-test-pr-py311 (langchain-cloud-sql-testing)"
Copy link
Collaborator

@kurtisvg kurtisvg Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we are skipping python 3.12?
tests/test_cloudsql_vectorstore_index.py Outdated

@pytest.mark.asyncio(scope="class")
@pytest.mark.skipif(
sys.version_info < (3, 11),
Copy link
Collaborator

@kurtisvg kurtisvg Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be !=?
@averikitsch averikitsch merged commit a3f410d into main Mar 15, 2024
@averikitsch averikitsch deleted the akitsch-versions branch March 15, 2024 23:29
@release-please release-please bot mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

2 participants

@averikitsch @kurtisvg