Skip to content

feat: raise InvalidGQLGenerationError on error with intermediate steps included #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

feat: raise InvalidGQLGenerationError on error with intermediate steps included #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868d365
fix(graph): raise InvalidGQLGenerationError with intermediate_steps
jordimas May 8, 2025
d8f9b13
Merge branch 'main' into issue_168
averikitsch Jul 21, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/langchain_google_spanner/graph_qa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ class VerifyGqlOutput(BaseModel):
INTERMEDIATE_STEPS_KEY = "intermediate_steps"


class InvalidGQLGenerationError(ValueError):
def __init__(self, message, intermediate_steps=None):
self.intermediate_steps = intermediate_steps
super().__init__(message)


class SpannerGraphQAChain(Chain):
"""Chain for question-answering against a Spanner Graph database by
generating GQL statements from natural language questions.
Expand Down Expand Up @@ -268,7 +274,9 @@ def execute_with_retry(
finally:
retries += 1

raise ValueError("The generated gql query is invalid")
raise InvalidGQLGenerationError(
"The generated gql query is invalid", intermediate_steps
)

def log_invalid_query(
self,
Expand Down Expand Up @@ -322,7 +330,9 @@ def _call(
_run_manager, intermediate_steps, question, verified_gql
)
if not final_gql:
raise ValueError("No GQL was generated.")
raise InvalidGQLGenerationError(
"No GQL was generated.", intermediate_steps
)
_run_manager.on_text("Full Context:", end="\n", verbose=self.verbose)
_run_manager.on_text(
str(context), color="green", end="\n", verbose=self.verbose
Expand Down