refactor: Reduce executor cache interface to one method #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
Genesis929 reviewed Nov 12, 2024
bigframes/session/executor.py Outdated
| ] = weakref.WeakKeyDictionary() | ||
| self.metrics = metrics | ||
| self.bqstoragereadclient = bqstoragereadclient | ||
| self.nondeterminism_only_once = (nondeterminism_only_once,) |
Collaborator
There was a problem hiding this comment.
self.nondeterminism_only_once seems not used?
Contributor Author
There was a problem hiding this comment.
sorry, leaked from some other changes I was working on. removed from new revision
Collaborator
There was a problem hiding this comment.
I don't see new commit, maybe you didn't push?
Contributor Author
There was a problem hiding this comment.
didn't actually push, now its pushed
TrevorBergeron force-pushed the only_once branch from 6a27589 to 8ca17e6 Compare Genesis929 approved these changes Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕