feat: add client_endpoints_override to bq options #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
Genesis929 approved these changes Nov 22, 2024
Genesis929 reviewed Nov 22, 2024
| @client_endpoints_override.setter | ||
| def client_endpoints_override(self, value: dict): | ||
| warnings.warn( | ||
| "This is an advanced option that sets the endpoints directly. Don't use if you don't know about it." |
Collaborator
There was a problem hiding this comment.
A example from GPT, "if you don't know about it.“ sounds too casual：
This is an advanced configuration option for directly setting endpoints. Incorrect use may lead to unexpected behavior or system instability. Proceed only if you fully understand its implications.
Genesis929 reviewed Nov 22, 2024
| skip_bq_connection_check: bool = False, | ||
| *, | ||
| ordering_mode: Literal["strict", "partial"] = "strict", | ||
| client_endpoints_override: dict = {}, |
Collaborator
There was a problem hiding this comment.
quick question, why not just endpoints_override.
Contributor Author
There was a problem hiding this comment.
Those are bq_xxx_client endpoints.
GarrettWu added the automerge Contributor Author
| failed samples are caused by #909, unrelated to this PR. |
gcf-merge-on-green bot removed the automerge 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
b/370077669