feat: support time_series_id_col in ARIMAPlus #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: l 
shuoweil added the kokoro:force-run 
bigframes-bot removed the kokoro:force-run 
GarrettWu reviewed Jan 13, 2025
| Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
auto-merge was automatically disabled January 20, 2025 01:34
Pull request was closed
product-auto-label bot added size: xl shuoweil requested review from GarrettWu and removed request for a team and msampathkumar product-auto-label bot added size: m product-auto-label bot added size: xl product-auto-label bot added size: m shuoweil force-pushed the shuowei-arima-plus branch from 8fbbb83 to 99c27d1 Compare product-auto-label bot added size: xl GarrettWu reviewed Jan 27, 2025
shuoweil force-pushed the shuowei-arima-plus branch from f25d88a to a373c4b Compare 
shuoweil force-pushed the shuowei-arima-plus branch from a373c4b to 51c51ee Compare GarrettWu approved these changes Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
feat: support time_series_id_col in ARIMAPlus,
(1) introduce time_series_id_col as an optional input feature, user needs to specific which column is used as time_series_id_col.
(2) update all testcases to test the original ARIMA plus model (without id_col) and new ARIMA plus model (with id_col).
(3) for generality test, expand the input dataset to include multiple ids for the same date