Skip to content

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 27, 2025

For example, now a user specified bq connection like "projects/project_id/locations/northamerica-northeast1/connections/conn-name" would also be supported.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 406526469 🦕

For example, now a user specified bq connection like "projects/project_id/locations/northamerica-northeast1/connections/conn-name" would also be supported.
@shobsi shobsi requested a review from GarrettWu March 27, 2025 00:46
@shobsi shobsi requested review from a team as code owners March 27, 2025 00:46
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 27, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 27, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 27, 2025
@GarrettWu
Copy link
Contributor

Thank you!

@shobsi shobsi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2025
@shobsi shobsi merged commit e7eb918 into main Mar 28, 2025
24 checks passed
@shobsi shobsi deleted the shobs-bq-conn-path-fmt branch March 28, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

4 participants