Skip to content

feat: DataFrames.__getitem__ support for slice input #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

feat: DataFrames.__getitem__ support for slice input #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bigframes/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,9 @@ def __getitem__(
if isinstance(key, bigframes.series.Series):
return self._getitem_bool_series(key)

if isinstance(key, slice):
return self.iloc[key]

if isinstance(key, typing.Hashable):
return self._getitem_label(key)
# Select a subset of columns or re-order columns.
Expand Down
15 changes: 15 additions & 0 deletions tests/system/small/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,21 @@ def test_get_column_nonstring(scalars_dfs):
assert_series_equal(bf_result, pd_result)


@pytest.mark.parametrize(
"row_slice",
[
(slice(1, 7, 2)),
(slice(1, 7, None)),
(slice(None, -3, None)),
],
)
def test_get_rows_with_slice(scalars_dfs, row_slice):
scalars_df, scalars_pandas_df = scalars_dfs
bf_result = scalars_df[row_slice].to_pandas()
pd_result = scalars_pandas_df[row_slice]
assert_pandas_df_equal(bf_result, pd_result)


def test_hasattr(scalars_dfs):
scalars_df, _ = scalars_dfs
assert hasattr(scalars_df, "int64_col")
Expand Down