- Notifications
You must be signed in to change notification settings - Fork 63
feat: Add concat pushdown for hybrid engine #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Add concat pushdown for hybrid engine
- Loading branch information
commit 660ecc89854532313a68ac25e9ca8fac28c780dd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| | ||
| import pytest | ||
| | ||
| from bigframes.core import array_value, ordering | ||
| from bigframes.session import polars_executor | ||
| from bigframes.testing.engine_utils import assert_equivalence_execution | ||
| | ||
| pytest.importorskip("polars") | ||
| | ||
| # Polars used as reference as its fast and local. Generally though, prefer gbq engine where they disagree. | ||
| REFERENCE_ENGINE = polars_executor.PolarsExecutor() | ||
| | ||
| | ||
| @pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True) | ||
| def test_engines_concat_self( | ||
| scalars_array_value: array_value.ArrayValue, | ||
| engine, | ||
| ): | ||
| catted = scalars_array_value.concat([scalars_array_value, scalars_array_value]) | ||
| assert_equivalence_execution(catted.node, REFERENCE_ENGINE, engine) | ||
| ||
| | ||
| | ||
| @pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True) | ||
| def test_engines_concat_filtered_sorted( | ||
| scalars_array_value: array_value.ArrayValue, | ||
| engine, | ||
| ): | ||
| input_1 = scalars_array_value.select_columns(["float64_col", "int64_col"]).order_by( | ||
| [ordering.ascending_over("int64_col")] | ||
| ) | ||
| input_2 = scalars_array_value.filter_by_id("bool_col").select_columns( | ||
| ["float64_col", "int64_too"] | ||
| ) | ||
| | ||
| catted = input_1.concat([input_2, input_1, input_2]) | ||
| assert_equivalence_execution(catted.node, REFERENCE_ENGINE, engine) | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming nit: "catted" -> "result". Otherwise I might have thought that the returned value is turned into a feline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done