- Notifications
You must be signed in to change notification settings - Fork 63
feat!: add allow_large_results option to read_gbq_query, aligning with bpd.options.compute.allow_large_results option #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
29 commits Select commit Hold shift + click to select a range
cdec057 feat: add `allow_large_results` option to `read_gbq_query`
tswast 3b78da7 add system test
tswast ad11cc8 Merge remote-tracking branch 'origin/main' into allow_large_results
tswast 68f1a10 add to pandas module
tswast b1e31e3 Merge branch 'main' into allow_large_results
tswast 3b770ae default to global option
tswast d01cdcb Merge remote-tracking branch 'origin/allow_large_results' into allow_…
tswast 10a8302 fix unit test
tswast 938fb89 tweak imports so I can manually run doctest
tswast 78d29f0 support index_col and columns
tswast 435c602 add system tests and fix pandas warning
tswast 7199fee Merge remote-tracking branch 'origin/main' into allow_large_results
tswast 778746f use global option in remaining functions
tswast 766640a Merge remote-tracking branch 'origin/main' into allow_large_results
tswast 95b2fdf supply allow_large_results=False when max_results is set
tswast 05c145c fix last? failing test
tswast e87b548 Merge branch 'main' into allow_large_results
tswast 58f45f8 fix vector search tests
tswast d611337 Merge remote-tracking branch 'origin/allow_large_results' into allow_…
tswast 6d0fe48 fix vector search tests again
tswast 8c27c2c fix arima tests
tswast 5ab21a9 fix more tests
tswast 2ca9e9e try again
tswast 0c8b88c and again
tswast 2a29309 Merge branch 'main' into allow_large_results
tswast 9362838 exclude ML results from jobless query path
tswast d3997ba fix unit tests
tswast 7cb3d55 add parameter for vector_search too
tswast 0a70173 fix doctest
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
allow_large_resultsalso default toNone? This would allow it to inherit its value fromComputeOptions.allow_large_results.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do so, it'd technicaly be a breaking change. Users with query results > 10 GB would have to set this option to
True.Might be worth it though for the consistency with other places, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.