Skip to content

fix: Use bytes limit on frame inlining rather than element count #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: Use bytes limit on frame inlining rather than element count #576

merged 1 commit into from
Apr 4, 2024

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Apr 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@TrevorBergeron TrevorBergeron requested review from a team as code owners April 4, 2024 02:05
@TrevorBergeron TrevorBergeron requested a review from GarrettWu April 4, 2024 02:05
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 4, 2024
@tswast tswast merged commit 659a161 into main Apr 4, 2024
@tswast tswast deleted the fix_inline_size branch April 4, 2024 16:36
@release-please release-please bot mentioned this pull request Apr 4, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@TrevorBergeron @Genesis929
fix: Use bytes limit on frame inlining rather than element count (#576)
99b7229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

2 participants

@TrevorBergeron @tswast