feat: merge only generates a default index if both inputs already have an index #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label bot added size: xl 
tswast commented May 29, 2024
| """Options to use with the BigQuery engine.""" | ||
| if self._local.bigquery_options is not None: | ||
| if ( | ||
| bigquery_options := getattr(self._local, "bigquery_options", None) |
Collaborator Author
There was a problem hiding this comment.
Not 100% sure how this was failing, but for some reason self._local.bigquery_options wasn't being initialized when I ran from a notebook in VS Code.
I think it's because the original Options.__init__ from the import ran in a different thread from the one where the actual cell code was running.
tswast commented May 29, 2024
tswast commented May 30, 2024
| @@ -0,0 +1,288 @@ | |||
| # Copyright 2024 Google LLC | |||
Collaborator Author
There was a problem hiding this comment.
Moved from tests/system/small/test_empty_index.py and added test_null_index_merge_* tests.
TrevorBergeron approved these changes May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕