Skip to content

refactor: remove circular dependencies preventing local doctest runs #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

refactor: remove circular dependencies preventing local doctest runs #987

merged 1 commit into from
Sep 13, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Sep 13, 2024

With this change I can once again run

pytest --doctest-modules third_party/bigframes_vendored/pandas/core/frame.py

Note: having multiple version.py files should be fine. release-please will update all such files it finds.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@tswast
refactor: remove circular dependencies preventing local doctest runs
197074a 
With this change I can once again run ``` pytest --doctest-modules third_party/bigframes_vendored/pandas/core/frame.py ``` Note: having multiple `version.py` files should be fine. release-please will update all such files it finds.
@tswast tswast requested review from a team as code owners September 13, 2024 19:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 13, 2024
sycai
sycai approved these changes Sep 13, 2024
View reviewed changes
third_party/bigframes_vendored/version.py
@@ -0,0 +1,15 @@
# Copyright 2022 Google LLC
Copy link
Contributor

@sycai sycai Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe 2024 ?
Copy link
Collaborator Author

@tswast tswast Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's copied from a filed that was copyright 2022, I'm inclined to leave this as-is. Not that there's much to copyright :-)
@tswast tswast enabled auto-merge (squash) September 13, 2024 19:24
@tswast tswast mentioned this pull request Sep 13, 2024
Merged
4 tasks
@tswast tswast merged commit 06c3120 into main Sep 13, 2024
@tswast tswast deleted the tswast-circular-import branch September 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@tswast @sycai @jiaxunwu