This repository was archived by the owner on Oct 29, 2023. It is now read-only.
chore: add README, nox support for MQTT example #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: cloudiot 
google-cla bot added the cla: yes 
gcseh force-pushed the mqtt-example-nox branch 2 times, most recently from bd6a208 to e715c14 Compare 
tseaver changed the title 
dandhlee suggested changes Sep 24, 2021
Contributor
dandhlee left a comment
dandhlee left a comment There was a problem hiding this comment.
Please see my comments below!
As well, docs prefix triggers a patch version bump, do we want that happening from this PR?
gcseh changed the title 
Contributor
| Discussed offline, closing the loop here; see example on adding temporary OwlBot changes to make it happy but also continue receiving template updates when needed. |
gcseh added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run gcseh force-pushed the mqtt-example-nox branch from 6ecccac to 5769331 Compare dandhlee approved these changes Sep 27, 2021
Contributor
dandhlee left a comment
dandhlee left a comment There was a problem hiding this comment.
LGTM, please see two actions items below.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix for #188