- Notifications
You must be signed in to change notification settings - Fork 68
chore(2.59.x): release 2.59.1-SNAPSHOT #3981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(2.59.x): release 2.59.1-SNAPSHOT #3981
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated release preparation, transitioning the project's internal dependencies to their next SNAPSHOT versions. This ensures that all components are aligned for continuous development and integration, allowing for the latest changes to be referenced across the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated chore to prepare for the 2.59.1-SNAPSHOT release by updating version numbers across various configuration and build files. The changes are mostly correct, but I've identified a couple of inconsistencies in versions.txt that could affect the release process. Specifically, the version for gax-httpjson is out of sync with its pom.xml and related modules, and the versions for gapic-showcase modules are being updated in versions.txt but not in their pom.xml files. Please see the detailed comments for suggestions on how to resolve these issues.
| api-common:2.50.0:2.50.1-SNAPSHOT | ||
| gax:2.67.0:2.67.1-SNAPSHOT | ||
| gax-grpc:2.67.0:2.67.1-SNAPSHOT | ||
| gax-httpjson:0.152.0:0.152.1-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for gax-httpjson appears to be incorrect. It's being updated to 0.152.1-SNAPSHOT, but its pom.xml is being updated to 2.67.1-SNAPSHOT to match the gax module's version, as indicated by the {x-version-update:gax:current} tag. To maintain consistency with other gax modules and its own pom.xml, this line should be updated to track the gax version correctly.
gax-httpjson:2.67.0:2.67.1-SNAPSHOT | gapic-showcase:0.5.0:0.5.1-SNAPSHOT | ||
| proto-gapic-showcase-v1beta1:0.5.0:0.5.1-SNAPSHOT | ||
| grpc-gapic-showcase-v1beta1:0.5.0:0.5.1-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions for gapic-showcase and its submodules are being updated in this file, but their corresponding pom.xml files are not being updated. The versions in java-showcase/pom.xml and its modules appear to be fixed at 0.0.1-SNAPSHOT. This inconsistency should be addressed. Either the pom.xml files for these modules should also be updated to reflect the new versions, or these modules should be removed from versions.txt if they are not intended to be versioned this way.
| This was created by: |
🤖 I have created a release beep boop
2.59.1-SNAPSHOT
Updating meta-information for bleeding-edge SNAPSHOT release.
This PR was generated with Release Please. See documentation.