Upgrade graphql-java to 2.3.0

[jplock]

Fixes #12

[jplock]

doh! looks like there are tests to fix or something.

[jplock]

I don't know how to fix these errors:

Gradle suite > Gradle test > graphql.servlet.GraphQLVariablesTest.nonNullvariableTyping FAILED java.lang.ClassCastException at GraphQLVariablesTest.java:89 Gradle suite > Gradle test > graphql.servlet.GraphQLVariablesTest.variableTyping FAILED java.lang.ClassCastException at GraphQLVariablesTest.java:69 

@yrashk any ideas?

[dminkovsky]

Hey, I reached out to the other maintainers.

In the meantime, when you say you don't know how to fix these errors, what do you mean? I'm not familiar with the project (not using the servlet API for GraphQL at this time), so I'm not sure exactly what the tests are doing. Looking at the code it looks like both failures occur at servlet.bindQueryProvider(queryProvider);. Any ideas what that line does?

[yrashk]

Guys, the project is not really abandoned — I am just being busy these days, hence dropping the ball on issues. I will be able to devote a bit more time in this coming month, but likely after Feb 15. Sorry about that!

…

On Fri, Feb 3, 2017 at 10:26 PM Dmitry Minkovsky ***@***.***> wrote: Hey, I reached out to the other maintainers. In the meantime, when you say you don't know how to fix these errors, what do you mean? I'm not familiar with the project (not using the servlet API for GraphQL at this time), so I'm not sure exactly what the tests are doing. Look at the code <https://github.com/graphql-java/graphql-java-servlet/blob/4aae2599e8667f762fcfd693e15b15a0320e4315/src/test/java/graphql/servlet/GraphQLVariablesTest.java> it looks like both failures occur at servlet.bindQueryProvider(queryProvider);. Any ideas what that line does? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABxA1nV1A52kG6qCogWIwfunM5YngIks5rY0cNgaJpZM4Ld55f> .

[dminkovsky]

We'll figure it out together as time permits! :) пт, 3 февр. 2017 г. в 10:36, Yurii Rashkovskii <notifications@github.com>:

…

Guys, the project is not really abandoned — I am just being busy these days, hence dropping the ball on issues. I will be able to devote a bit more time in this coming month, but likely after Feb 15. Sorry about that! On Fri, Feb 3, 2017 at 10:26 PM Dmitry Minkovsky ***@***.*** > wrote: > Hey, I reached out to the other maintainers. > > In the meantime, when you say you don't know how to fix these errors, what > do you mean? I'm not familiar with the project (not using the servlet API > for GraphQL at this time), so I'm not sure exactly what the tests are > doing. Look at the code > < https://github.com/graphql-java/graphql-java-servlet/blob/4aae2599e8667f762fcfd693e15b15a0320e4315/src/test/java/graphql/servlet/GraphQLVariablesTest.java > > it looks like both failures occur at > servlet.bindQueryProvider(queryProvider);. Any ideas what that line does? > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > < #13 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAABxA1nV1A52kG6qCogWIwfunM5YngIks5rY0cNgaJpZM4Ld55f > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANWZTjPCEHf1dJzmtzOpgw8pj08E5gYks5rY0lngaJpZM4Ld55f> .

[jplock]

Sorry @dminkovsky I should have been more clear. The test suite for this project doesn't do a whole lot and it looks like the test failures are coming somewhere within graphql-java itself (those java.lang.ClassCastException exceptions). That's why I'm not sure how best to fix it.

I appreciate everyone's help with this.

[apottere]

@yrashk Any chance you could come back to the project soon? I'm happy to help maintain it if you can't.

Otherwise I might end up maintaining a fork - I love what you've done here, but a few people (myself included) need it to move forward.

[yrashk]

@apottere, I am happy to delegate maintenance — I completely lack time to maintain this library right now.

[apottere]

@yrashk awesome, let me know how you want to proceed.

[yrashk]

@apottere I sent a request to @andimarek to add you as a project maintainer/admin. I will also need you to sign up for Maven Central releases functionality at https://issues.sonatype.org

[apottere]

I'm ddcapotter on https://issues.sonatype.org

[apottere]

@jplock The test errors were because the object in the tests used the same java class for input and output, causing graphql-java-annotations to create two different types (input and object) with the same name. When the schema tried to look up the type from the dictionary, it got the wrong one and couldn't cast it to the correct type.