Extract queryProviders, mutationProviders, and typeProviders behind a schemaProvider. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
apottere commented Jan 12, 2017
| public void bindQueryProvider(GraphQLQueryProvider queryProvider) { | ||
| queryProviders.add(queryProvider); | ||
| updateSchema(); | ||
| @Reference(cardinality = ReferenceCardinality.MANDATORY, policyOption = ReferencePolicyOption.GREEDY) |
apottere commented Jan 12, 2017
| import java.util.List; | ||
| import java.util.Set; | ||
| | ||
| public class OsgiSchemaProvider extends GraphQLSchemaProvider implements Serializable { |
Contributor Author
There was a problem hiding this comment.
Do I need any OSGI annotations here?
Contributor Author
| @yrashk Any chance you'll be able to look at this soon? I'm currently using a workaround (extending the class in the same package) to set the schema manually, but it's pretty hacky. |
This was referenced Feb 28, 2017
Contributor Author
| Since I don't really know how to make sure I'm not breaking the OSGI support, I'm going to revisit the original strategy of #14. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per #14, I extracted the other providers behind a "schemaProvider" that can be injected into the servlet instead.
I have no experience with OSGI, so I need help making sure that will all wire correctly (it probably won't in its current state).