Fix OSGi service registration #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks! I don't actually use OSGi so I wasn't aware this was broken 👎 |
Contributor
| This is released in |
Contributor Author
| Thanks for releasing that quickly that really is a big help. I'm using graphql-java-servlet in a couple of OSGi projects so I'll keep you posted if I see anymore issues or have suggestions for improvements. |
Contributor
| That's perfect, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
I was testing the OSGi servlet with Apache Karaf 4.1.1 and it was not working. I saw that the component was not being properly registered as a HttpServlet service so I added an explicit service class registration which fixed the problem.