Skip to content

Do not include "servlet-api" dependency #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not include "servlet-api" dependency #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not include "servlet-api" dependency 
The servlet API is typically provided by the servlet container.
  • Loading branch information
@dheid
dheid authored May 9, 2022
commit 5a6207cc32b666aac5d17e0a727f2367c801f9e4
2 changes: 1 addition & 1 deletion graphql-java-servlet/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies {
api(project(':graphql-java-kickstart'))

// Servlet
api 'javax.servlet:javax.servlet-api:4.0.1'
compileOnly 'javax.servlet:javax.servlet-api:4.0.1'
Copy link
Member

@oliemansm oliemansm May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add it to be available for the tests so they can run.
api 'javax.websocket:javax.websocket-api:1.1'
implementation "org.slf4j:slf4j-api:$LIB_SLF4J_VER"

Expand Down