Rework directives #663
Merged
Rework directives #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oryan-block commented May 17, 2022
| | ||
| private fun <T : GraphQLDirectiveContainer> wireDirectives(wrapper: WiringWrapper<T>) { | ||
| val directivesContainer = wrapper.graphQlType.definition as DirectivesContainer<*> | ||
| val directives = buildDirectives(directivesContainer.directives, wrapper.directiveLocation) |
Collaborator Author
There was a problem hiding this comment.
Still waiting for an answer to my question here but building these directives on the fly seems to be the most likely solution, assuming that SchemaDirectiveWiringEnvironment#getDirective/s remains not deprecated and we have to supply them somehow.
Collaborator Author
There was a problem hiding this comment.
Note: this was fixed in graphql-java/graphql-java#2834
Still, we should only remove this once the deprecated methods are removed.
oryan-block force-pushed the rework-directives branch from 12a3b17 to 236d20c Compare oryan-block force-pushed the rework-directives branch 2 times, most recently from fbfdacb to 673b343 Compare oryan-block force-pushed the rework-directives branch from 673b343 to 9dfa462 Compare oryan-block commented May 19, 2022
| } | ||
| | ||
| @Test | ||
| fun `should apply repeated directive`() { |
vojtapol approved these changes May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Following the addition of applied directives in v18 I wanted to have a permanent solution to how we handle directives.
This ended up being mostly a re-implementation of
SchemaGeneratorDirectiveHelperso I'm not sure of the benefit.The upside is that we no longer depend on copy-pasted code or deprecated API methods to wire the directives.