Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jun 23, 2025

Related issue: #7286

This reverts commit a64d933.

This change is breaking an internal test cl/774621745. A rollback is being performed to fix the broken test while we investigate the failure.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.74 Release milestone Jun 23, 2025
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (bdbe6a2) to head (2db9aa5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
stream.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #8404 +/- ## ========================================== - Coverage 82.43% 82.39% -0.04%  ========================================== Files 413 413 Lines 40430 40424 -6 ========================================== - Hits 33328 33309 -19  - Misses 5751 5754 +3  - Partials 1351 1361 +10 
Files with missing lines Coverage Δ
stream.go 81.65% <50.00%> (+0.15%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@arjan-bal arjan-bal changed the title grpc: Revert #8278: Fix cardinality violations in non-server streaming RPs grpc: revert #8278: Fix cardinality violations in non-server streaming RPs Jun 23, 2025
@Pranjali-2501 Pranjali-2501 self-requested a review June 23, 2025 18:48
@arjan-bal arjan-bal changed the title grpc: revert #8278: Fix cardinality violations in non-server streaming RPs grpc: revert #8278: Fix cardinality violations in non-server streaming RPCs Jun 23, 2025
@arjan-bal arjan-bal merged commit 20bd1e7 into grpc:master Jun 23, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants