Merged
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #1006 +/- ## ======================================== Coverage 26.11% 26.11% ======================================== Files 402 402 Lines 12821 12821 ======================================== Hits 3348 3348 Misses 9473 9473 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a warning when a user submits an ATT&CK config that could be unsafe.
The ATT&CK configuration screen could allow users to unknowingly submit a potentially unsafe configuration.
Example
Exploitsand enable an unsafe exploiter.ATT&CKconfiguration screen and click submit -- You are not warned that the config may be unsafeSolution
When ATT&CK configurations are submitted, the workflow is:
The ATT&CK configuration does not contain enough information for the front-end to simply determine whether or not it is safe. Therefore, the front-end relies on the back-end to translate the ATT&CK config into a regular config before it can evaluate safety. The front-end can then only warn the user, not prevent submission as in #1000.
PR Checklist
Testing Checklist