Hash login password on server side with bcrypt#1139
Merged
mssalvatore merged 29 commits intodevelopfrom May 5, 2021
Merged
Conversation
…vices/AuthService.js
Codecov Report
@@ Coverage Diff @@ ## develop #1139 +/- ## =========================================== - Coverage 28.71% 28.64% -0.08% =========================================== Files 410 411 +1 Lines 12877 12892 +15 =========================================== - Hits 3698 3693 -5 - Misses 9179 9199 +20
Continue to review full report at Codecov.
|
Closed
In python, private static methods serve no purpose. Python has first-class functions; let's use them.
7 tasks
The default values were only really used by the test code. We can simplify the Usercreds's interface and test code by removing functionality (read: complication) we don't really need.
shreyamalviya commented May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969
Uses bcrypt to salt and hash the password on the server side before storing it.
PR Checklist
Testing Checklist