Skip to content

Create a temporary directory for zerologon artifacts#1143

Merged
mssalvatore merged 2 commits intodevelopfrom
zerologon-tmp-dir
May 4, 2021
Merged

Create a temporary directory for zerologon artifacts#1143
mssalvatore merged 2 commits intodevelopfrom
zerologon-tmp-dir

Conversation

@mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented May 4, 2021

What does this PR do?

Zerologon exploiter writes runtime artifacts to a secure temporary directory instead of $HOME

This PR is in support of #1133.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the zerologon blackbox test.

  • If applicable, add screenshots or log transcripts of the feature working
Not all users are guaranteed to have a $HOME. Use a temporary directory instead.
@mssalvatore mssalvatore requested a review from shreyamalviya May 4, 2021 12:35
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1143 (93bb14f) into develop (7f06ec4) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #1143 +/- ## =========================================== + Coverage 28.71% 28.73% +0.01%  =========================================== Files 410 410 Lines 12877 12883 +6 =========================================== + Hits 3698 3702 +4  - Misses 9179 9181 +2 
Impacted Files Coverage Δ
...ion_monkey/exploit/zerologon_utils/remote_shell.py 17.70% <33.33%> (-0.19%) ⬇️
...nfection_monkey/exploit/zerologon_utils/wmiexec.py 33.33% <50.00%> (-0.82%) ⬇️
monkey/infection_monkey/exploit/zerologon.py 30.82% <80.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f06ec4...93bb14f. Read the comment docs.

@mssalvatore mssalvatore merged commit 341af22 into develop May 4, 2021
@mssalvatore mssalvatore deleted the zerologon-tmp-dir branch May 4, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants