Remove dead python code reported by Vulture#1149
Conversation
Using these specific names prevents Vulture from identifying these parameters as unused.
…zero_trust/test_common/monkey_finding_data.py`
…vices/reporting/report.py`
…es/post_breach_files.py`
…by_id()` in `monkey_island/cc/services/node.py`
…/services/attack/attack_report.py`
…s/auth/user_store.py`
…d/cc/models/monkey.py`
…TTP` in `infection_monkey/model/__init__.py`
…breach/post_breach_handler.py`
…)`, and `_traceroute_linux` from `infection_monkey/network/tools.py`
…/post_breach_handler.py`
…et_region()` from `monkey_island/cc/environment/aws.py`
…inTests/ComboFile.py`
…fo/wmi_consts.py`
…`infection_monkey/network/tools.py`
…ion_monkey/network/tools.py`
…/exploit/web_rce.py`
…_COPY_FILENAME_64` in `infection_monkey/exploit/sambacry.py`
…nfection_monkey/example.conf`
…info_collectors_names.py`
…mon/cloud/aws/aws_service.py`
…st_user_creds.py`
mssalvatore left a comment
mssalvatore left a comment There was a problem hiding this comment.
I've stripped out the irrelevant portion of the path from the whitelist and added it.
| return "tcp-" + str(port) | ||
| | ||
| | ||
| def traceroute(target_ip, ttl=64): |
There was a problem hiding this comment.
@VakarisZ Are we using traceroute anywhere anymore? If not, can we get rid of everything that references the binaries (e.g. deployment scripts and release documentation).
| class BootloaderHttpServer(ThreadingMixIn, HTTPServer): | ||
| def __init__(self, mongo_url): | ||
| self.mongo_client = pymongo.MongoClient(mongo_url) | ||
| pymongo.MongoClient(mongo_url) |
There was a problem hiding this comment.
What does this call achieve if we're not using the object it returns?
Codecov Report
@@ Coverage Diff @@ ## develop #1149 +/- ## =========================================== - Coverage 28.66% 28.62% -0.04% =========================================== Files 411 411 Lines 12898 12744 -154 =========================================== - Hits 3697 3648 -49 + Misses 9201 9096 -105
Continue to review full report at Codecov.
|
2 participants
Fixes #1123
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working