Skip to content

BB tests: automatic registration#1180

Merged
VakarisZ merged 4 commits intodevelopfrom
bb_test_gcp_authentication_fix
May 21, 2021
Merged

BB tests: automatic registration#1180
VakarisZ merged 4 commits intodevelopfrom
bb_test_gcp_authentication_fix

Conversation

@VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented May 20, 2021 •
edited
Loading

What does this PR do?

EtE tests deploy the island, but island prompts a registration screen, which BB can't handle.
This PR solves that problem by selecting a passwordless option.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested with an unregistred island (registration successful)
    Tested with a registered island (authentication error is thrown, tests don't run)
    Tested with unreachable island ("can't reach island" error message is displayed, tests don't run)
@VakarisZ VakarisZ requested a review from shreyamalviya May 20, 2021 05:53
@ghost
Copy link

ghost commented May 20, 2021 •
edited by ghost
Loading

DeepCode's analysis on #49e63f found:

  • ❌ 1 critical issue 👇

Top issues

Description Example fixes
(BETA suggestion) Certificate verification is disabled by setting verify to False in requests.post. This may lead to Man-in-the-middle attacks. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot
@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #1180 (49e63fc) into develop (6eb3778) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #1180 +/- ## ======================================== Coverage 28.91% 28.91% ======================================== Files 418 418 Lines 12780 12780 ======================================== Hits 3695 3695 Misses 9085 9085

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb3778...49e63fc. Read the comment docs.
@VakarisZ VakarisZ force-pushed the bb_test_gcp_authentication_fix branch from 3cc646b to cc365a7 Compare May 20, 2021 13:49
shreyamalviya
shreyamalviya reviewed May 20, 2021
View reviewed changes
envs/monkey_zoo/blackbox/test_blackbox.py Outdated
island_client_object = MonkeyIslandClient(island)
client_established = island_client_object.get_api_status()
except Exception:
logging.exception("message")
Copy link
Contributor

@shreyamalviya shreyamalviya May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a more descriptive message?
Copy link
Contributor Author

@VakarisZ VakarisZ May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed
@shreyamalviya shreyamalviya self-requested a review May 21, 2021 09:19
@VakarisZ VakarisZ merged commit 7b02ceb into develop May 21, 2021
@VakarisZ VakarisZ deleted the bb_test_gcp_authentication_fix branch May 21, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@VakarisZ @shreyamalviya