Agent: Format config log messages so they are readable#1283
Merged
mssalvatore merged 1 commit intodevelopfrom Jun 30, 2021
Merged
Agent: Format config log messages so they are readable#1283mssalvatore merged 1 commit intodevelopfrom
mssalvatore merged 1 commit intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #1283 +/- ## =========================================== - Coverage 30.68% 30.68% -0.01% =========================================== Files 449 449 Lines 13466 13470 +4 =========================================== + Hits 4132 4133 +1 - Misses 9334 9337 +3
Continue to review full report at Codecov.
|
VakarisZ approved these changes Jun 30, 2021
Contributor
VakarisZ left a comment
There was a problem hiding this comment.
Nice changes, but there's one more logging of config in monkey/infection_monkey/control.py:210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When monkey agent logs its default/new configuration, format the output so it is more easily readable.
Add any further explanations here.
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Screenshots