Skip to content

Agent: Format config log messages so they are readable#1283

Merged
mssalvatore merged 1 commit intodevelopfrom
config-log-formatting
Jun 30, 2021
Merged

Agent: Format config log messages so they are readable#1283
mssalvatore merged 1 commit intodevelopfrom
config-log-formatting

Conversation

@mssalvatore
Copy link
Collaborator

What does this PR do?

When monkey agent logs its default/new configuration, format the output so it is more easily readable.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    See screenshot

  • If applicable, add screenshots or log transcripts of the feature working

Screenshots

image

@mssalvatore mssalvatore requested a review from VakarisZ June 30, 2021 12:10
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #1283 (f3e7976) into develop (3fb8c06) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #1283 +/- ## =========================================== - Coverage 30.68% 30.68% -0.01%  =========================================== Files 449 449 Lines 13466 13470 +4 =========================================== + Hits 4132 4133 +1  - Misses 9334 9337 +3 
Impacted Files Coverage Δ
monkey/infection_monkey/main.py 0.00% <0.00%> (ø)
monkey/infection_monkey/control.py 22.07% <33.33%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb8c06...f3e7976. Read the comment docs.

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, but there's one more logging of config in monkey/infection_monkey/control.py:210

@mssalvatore mssalvatore merged commit 8735724 into develop Jun 30, 2021
@mssalvatore mssalvatore deleted the config-log-formatting branch June 30, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants