Conversation
This change cleans up the code because the info collectors can just add credentials to the info dictionary without explicitly checking if the key already exists
Codecov Report
@@ Coverage Diff @@ ## develop #1512 +/- ## ======================================== Coverage 42.99% 43.00% ======================================== Files 477 477 Lines 14174 14171 -3 ======================================== Hits 6094 6094 + Misses 8080 8077 -3
Continue to review full report at Codecov.
|
mssalvatore approved these changes Oct 5, 2021
Collaborator
mssalvatore left a comment
There was a problem hiding this comment.
Approved but needs changelog
…tor when Azure credential collector is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where mimikatz data doesn't get collected whenever the azure collector is disabled
Add any further explanations here.
PR Checklist
Testing Checklist