Fix ATT&CK report bug: showed a different technique's results under a technique if the PBA behind them was the same#1514
Merged
mssalvatore merged 7 commits intodevelopfrom Oct 6, 2021
Conversation
…check telem event's OS and technique's relevant systems
Codecov Report
@@ Coverage Diff @@ ## develop #1514 +/- ## ======================================== Coverage 42.99% 42.99% ======================================== Files 477 477 Lines 14173 14170 -3 ======================================== - Hits 6094 6093 -1 + Misses 8079 8077 -2
Continue to review full report at Codecov.
|
mssalvatore reviewed Oct 6, 2021
CHANGELOG.md Outdated
| the config successfully now.) #1490 | ||
| - Mimikatz collector no longer fails if Azure credential collector is disabled. #1512 #1493 | ||
| - Unhandled error when "modify shell startup files PBA" is unable to find regular users. #1507 | ||
| - ATT&CK report bug that showed a different technique's results under a technique if the PBA behind |
Collaborator
There was a problem hiding this comment.
Suggested change
| - ATT&CK report bug that showed a different technique's results under a technique if the PBA behind | |
| - ATT&CK report bug that showed a different techniques' results under a technique if the PBA behind |
…ile` and `.bashrc`" technique
of the first entry in the PBA's results
b62d7ea to 5be841d Compare Contributor Author
| After 5be841d: For PBAs with multiple entries in |
ilija-lazoroski approved these changes Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What does this PR do?
Fixes #1480 and fixes #1511
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist