Remove old Agent registration logic#2542
Merged
shreyamalviya merged 12 commits intodevelopfrom Nov 3, 2022
Merged
Conversation
VakarisZ reviewed Nov 3, 2022
VakarisZ reviewed Nov 3, 2022
| from monkey_island.cc.server_utils.consts import DEFAULT_MONKEY_TTL_EXPIRY_DURATION_IN_SECONDS | ||
| | ||
| | ||
| class Monkey(Document): |
Contributor
There was a problem hiding this comment.
This whole file also should go. Instead of get_latest_modifytime we can just fetch the timestamp of the latest event
Contributor
There was a problem hiding this comment.
I am working on to see do we actually need the modifytime.
Contributor
There was a problem hiding this comment.
Hmmm, maybe not. Removing Monkey would require more work, but we can certainly replace the get_latest_modifytime
Contributor Author
There was a problem hiding this comment.
I'd rather not touch that code in this PR since Ilija is working on it as part of #2507.
VakarisZ requested changes Nov 3, 2022
Contributor
VakarisZ left a comment
VakarisZ left a comment There was a problem hiding this comment.
Remove monkey/infection_monkey/control.py as well
VakarisZ approved these changes Nov 3, 2022
Contributor
VakarisZ left a comment
VakarisZ left a comment There was a problem hiding this comment.
Approved, but fix vulture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2272
And removes other related, now unused, code
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working