3137 new token pair endpoint by shreyamalviya · Pull Request #3181 · guardicore/monkey

shreyamalviya · 2023-03-31T07:08:31Z

What does this PR do?

Fixes a part of #3137

PR Checklist

Have you added an explanation of what your changes do and why you'd like to include them?
Is the TravisCI build passing?
Was the CHANGELOG.md updated to reflect the changes?
~~Was the documentation framework updated to reflect the changes?~~
Have you checked that you haven't introduced any duplicate code?

Testing Checklist

Added relevant unit tests?
Do all unit tests pass?
~~Do all end-to-end tests pass?~~
Any other testing performed?

Tested the endpoint manually
~~If applicable, add screenshots or log transcripts of the feature working~~

codecov · 2023-03-31T08:08:01Z

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (37acd73) 72.50% compared to head (17e2755) 72.63%.

❗ Current head 17e2755 differs from pull request most recent head 315c23c. Consider uploading reports for the commit 315c23c to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@ ## develop #3181 +/- ## =========================================== + Coverage 72.50% 72.63% +0.13%  =========================================== Files 467 468 +1 Lines 13295 13344 +49 =========================================== + Hits 9640 9693 +53  + Misses 3655 3651 -4

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

monkey/monkey_island/cc/services/authentication_service/flask_resources/__init__.py

monkey/monkey_island/cc/services/authentication_service/token/token_validator.py

...ts/unit_tests/monkey_island/cc/services/authentication_service/token/test_token_validator.py

...s/unit_tests/monkey_island/cc/services/authentication_service/test_authentication_service.py

mssalvatore

I added the "needs registration" tests back in and they fail. These tests MUST be here and they MUST pass.

monkey/monkey_island/cc/services/authentication_service/flask_resources/token.py

...s/unit_tests/monkey_island/cc/services/authentication_service/test_authentication_service.py

If a new refresh token is generated, even if the old token isn't expired yet, the new one should be invalidated. We shouldn't have two valid refresh tokens for a user.

These tests were removed in the previous commit, but test security-critical portions of the authentication system. They MUST exist and they MUST pass.

token endpoint

All ParsedToken objects are valid at the time of creation. They have a valid signature and not be expired. Since the token may expire sometime after the object is created, `is_expired()` is provided so that other components may check expiration at a later time.

Since TokenParser will not return an invalid token, there is no longer any need to call TokenValidator.validate_token().

VakarisZ force-pushed the 3137-send-refresh-token branch from 08e396a to 7b68728 Compare March 31, 2023 07:30

shreyamalviya force-pushed the 3137-new-token-pair-endpoint branch from 0806d84 to c6c31ca Compare March 31, 2023 07:38

shreyamalviya changed the base branch from 3137-send-refresh-token to develop March 31, 2023 07:39

VakarisZ force-pushed the 3137-new-token-pair-endpoint branch from c6c31ca to 1cf264a Compare March 31, 2023 08:01

VakarisZ marked this pull request as ready for review March 31, 2023 08:01