Skip to content

3168 verify supported operating system#3275

Merged
mssalvatore merged 6 commits intodevelopfrom
3168-verify-supported-operating-system
Apr 28, 2023
Merged

3168 verify supported operating system#3275
mssalvatore merged 6 commits intodevelopfrom
3168-verify-supported-operating-system

Conversation

@mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Apr 28, 2023

What does this PR do?

Issue #3168

Add the ability to verify supported operating system compatability.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2a35a3d) 73.52% compared to head (c808b87) 73.51%.

❗ Current head c808b87 differs from pull request most recent head 4f5f476. Consider uploading reports for the commit 4f5f476 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@ ## develop #3275 +/- ## =========================================== - Coverage 73.52% 73.51% -0.01%  =========================================== Files 484 484 Lines 13949 13968 +19 =========================================== + Hits 10256 10269 +13  - Misses 3693 3699 +6 

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

itself up.
:raises IncompatibleOperatingSystemError: If an exploiter is not compatible with the target
host's operating system
:raises IncompatibleTargetOperatingSystemError: If an exploiter is not compatible with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this also raises IncompatibleLocalOperatingSystemError

@mssalvatore mssalvatore force-pushed the 3168-verify-supported-operating-system branch from c808b87 to 4f5f476 Compare April 28, 2023 14:22
@mssalvatore mssalvatore force-pushed the 3168-verify-supported-operating-system branch from 4f5f476 to 1cd4456 Compare April 28, 2023 14:23
@mssalvatore mssalvatore merged commit 42b8149 into develop Apr 28, 2023
@mssalvatore mssalvatore deleted the 3168-verify-supported-operating-system branch April 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants