Merged
Conversation
…cted, we don't need to see the error trace.
monkey/infection_monkey/exploit/zerologon_utils/vuln_assessment.py Outdated Show resolved Hide resolved
monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js Outdated Show resolved Hide resolved
monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js Outdated Show resolved Hide resolved
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Co-authored-by: Shreya Malviya <shreya.malviya@gmail.com>
Co-authored-by: Shreya Malviya <shreya.malviya@gmail.com>
VakarisZ commented Mar 1, 2021
Comment on lines +135 to +139
| "account and could prevent the victim domain controller from communicating " | ||
| "with other domain controllers. While it attempts to undo " | ||
| "its changes and reset the password back to the original after the " | ||
| "vulnerability is exploited, this is not successful in all cases. For " | ||
| "instructions on how to reset the domain controller's password, see the documentation.", |
Contributor Author
There was a problem hiding this comment.
Suggested change
| "account and could prevent the victim domain controller from communicating " | |
| "with other domain controllers. While it attempts to undo " | |
| "its changes and reset the password back to the original after the " | |
| "vulnerability is exploited, this is not successful in all cases. For " | |
| "instructions on how to reset the domain controller's password, see the documentation.", | |
| "account and then attempts to restore it. Victim domain controller can't communicate " | |
| "with other domain controllers until the password is restored. If the Infection Monkey fails to " | |
| "restore the password automatically, you'll have to do it manually. For more information see the " | |
| "documentation.", |
… be more consistent with the function of issue map.
Codecov Report
@@ Coverage Diff @@ ## develop #998 +/- ## =========================================== + Coverage 26.11% 26.13% +0.02% =========================================== Files 402 402 Lines 12821 12830 +9 =========================================== + Hits 3348 3353 +5 - Misses 9473 9477 +4
Continue to review full report at Codecov.
|
mssalvatore approved these changes Mar 1, 2021
shreyamalviya approved these changes Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #991 and fixes #989
Add any further explanations here.
PR Checklist