Improve Linux performance of GetAllInterfaces#47
Open
wjordan wants to merge 1 commit intohashicorp:masterfrom
Open
Improve Linux performance of GetAllInterfaces#47wjordan wants to merge 1 commit intohashicorp:masterfrom
wjordan wants to merge 1 commit intohashicorp:masterfrom
Conversation
This Linux optimization avoids a separate Netlink dump of addresses for each individual interface, which is prohibitively slow on servers with large numbers of interfaces.
sean- approved these changes May 14, 2024
| +1 to Merge. It is a useful performance fix when dealing with tons of interfaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Linux-specific optimization avoids a separate Netlink dump of addresses for each individual interface, which is prohibitively slow on servers with a large number (thousands) of network interfaces.
Here are some example test results on a sample server using the
sockaddr evalcommand (which providessockaddr.GetAllInterfaces()as template data), showing a ~100x performance improvement:See golang/go#53660 for further discussion of this Linux performance issue with
net.Interface.