Remove uses of MonadFail (ST _) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a use of `fail` for `Maybe` which is entirely pointless.
andreasabel force-pushed the monadfail-ST branch from 05b2f9a to 1afa860 Compare netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 18, 2022
### 1.3.2 _2022-07-18, Andreas Abel_ - Export `decodePatternSet` and `decodeCharacterClass` from `Text.Regex.TDFA.Pattern` ([#16](haskell-hvr/regex-tdfa#16)) - Extend and correct docs for `Pattern` module - Tested with GHC 7.4 - 9.4 ### 1.3.1.5 _2022-07-18, Andreas Abel_ - Allow dash (`-`) as start of a range, e.g. `[--z]` ([#1](haskell-hvr/regex-tdfa#1), [#45](haskell-hvr/regex-tdfa#45)) - Tested with GHC 7.4 - 9.4 ### 1.3.1.4 _2022-07-17, Andreas Abel_ - Fix parsing of dashes in bracket expressions, e.g. `[-a-z]` ([#1](haskell-hvr/regex-tdfa#1)) - Fix a deprecation warning except for on GHC 8.2 ([#21](haskell-hvr/regex-tdfa#21)) - Documentation: link `defaultComptOpt` to its definition ([#13](haskell-hvr/regex-tdfa#13)) - Verify documentation examples with new `doc-test` testsuite - Tested with GHC 7.4 - 9.4 ### 1.3.1.3 _2022-07-14, Andreas Abel_ - Fix an `undefined` in `Show PatternSet` ([#37](haskell-hvr/regex-tdfa#37)) - Document POSIX character classes (e.g. `[[:digit:]]`) in README - Tested with GHC 7.4 - 9.4 ### 1.3.1.2 Revision 1 _2022-05-25, Andreas Abel_ - Allow `base >= 4.17` (GHC 9.4) ### 1.3.1.2 _2022-02-19, Andreas Abel_ - No longer rely on the `MonadFail` instance for `ST` (future `base` library change, see [#29](haskell-hvr/regex-tdfa#29)). - Silence warning `incomplete-uni-patterns` (GHC >= 9.2). - Import from `Data.List` explicitly or qualified (warning `compat-unqualified-imports`). - Import from `Control.Monad` to allow `mtl-2.3` in its `rc3` incarnation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
haskell/core-libraries-committee#33 : Remove uses of
MonadFail (ST _)Also:
failforMaybewhich is entirely pointless.NewDFA/Engine_FA