Skip to content

Remove shadowed search function from StringUtil#1750

Merged
disconcision merged 1 commit intodevfrom
fix-build-07-02
Jul 2, 2025
Merged

Remove shadowed search function from StringUtil#1750
disconcision merged 1 commit intodevfrom
fix-build-07-02

Conversation

@7h3kk1d
Copy link
Contributor

@7h3kk1d 7h3kk1d commented Jul 2, 2025 •
edited
Loading

To fix the build
@7h3kk1d 7h3kk1d requested review from cyrus- and disconcision July 2, 2025 23:12
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (b552595) to head (51799ea).
Report is 26 commits behind head on dev.

Additional details and impacted files 
@@ Coverage Diff @@ ## dev #1750 +/- ## ========================================== + Coverage 51.58% 55.00% +3.42%  ========================================== Files 136 140 +4 Lines 14736 15883 +1147 ========================================== + Hits 7601 8737 +1136  - Misses 7135 7146 +11
Files with missing lines Coverage Δ
src/util/StringUtil.re 80.00% <ø> (+1.95%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
disconcision
disconcision approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@disconcision disconcision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@disconcision disconcision merged commit bfae450 into dev Jul 2, 2025
4 checks passed
@disconcision disconcision deleted the fix-build-07-02 branch July 2, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@7h3kk1d @disconcision