SystemStackError if counter column is named otp_counter #26
Description
Followed the Counter based OTP guide.
$ rails g migration AddOtpSecretKeyToUsers otp_secret_key:string $ rails g migration AddCounterForOtpToUsers otp_counter:integer $ rails g migration AddCounterForOtpToUsers my_otp_counter:integer # Set the default value to `1` manually $ rake db:migrateclass User < ActiveRecord::Base has_one_time_password :counter_based => true endu = User.new # => #<User id: nil, email: nil, otp_counter: 1, otp_secret_key: nil, created_at: nil, updated_at: nil, my_otp_counter: 1> u.otp_counter SystemStackError: stack level too deep from /usr/local/rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/irb/workspace.rb:86 Maybe IRB bug!class User < ActiveRecord::Base has_one_time_password :counter_based => true, :counter_column_name => :my_otp_counter endu = User.new # => #<User id: nil, email: nil, otp_counter: 1, otp_secret_key: nil, created_at: nil, updated_at: nil, my_otp_counter: 1> u.otp_counter # => 1Not sure why the same problem isn't exhibited by the specs, but the following seems to fix the problem:
module ActiveModel module OneTimePassword module InstanceMethodsOnActivation def otp_counter if self.class.otp_counter_column_name != 'otp_counter' self.public_send(self.class.otp_counter_column_name) else super end end def otp_counter=(attr) if self.class.otp_counter_column_name != 'otp_counter' self.public_send("#{self.class.otp_counter_column_name}=", attr) else super end end end end end