Release v1.17.0 #1437
Merged
Release v1.17.0 #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
andrey-kashcheev left a comment
andrey-kashcheev left a comment There was a problem hiding this comment.
Please see previous changelogs for examples of how to form it as it is not equal to git log
HalynaDumych suggested changes Oct 9, 2023
CHANGELOG.md Outdated
| * Improved support of HTTP proxy on iOS. | ||
| * Cleaned up DNS cache on error in CURL (Android). | ||
| * Moved all jobs to Github Actions. | ||
| * Fixed cmake scripts. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fixed cmake scripts. | |
| * Fixed the CMake scripts. |
CHANGELOG.md Outdated
Comment on lines 9 to 10
| * Improved logging in PendingUrlRequests. | ||
| * Added StreamLayerPartitions API. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Improved logging in PendingUrlRequests. | |
| * Added StreamLayerPartitions API. | |
| * Improved logging in `PendingUrlRequests`. | |
| * Added the `StreamLayerPartitions` API. |
CHANGELOG.md Outdated
| * Cleaned up DNS cache on error in CURL (Android). | ||
| * Moved all jobs to Github Actions. | ||
| * Fixed cmake scripts. | ||
| * Added possibility to specify DNS in network request. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added possibility to specify DNS in network request. | |
| * Added the possibility to specify DNS in network requests. |
CHANGELOG.md Outdated
| * Improved logging in PendingUrlRequests. | ||
| * Added StreamLayerPartitions API. | ||
| * Fixed the CMakeLists file. | ||
| * Fix to show more log info in prod build. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fix to show more log info in prod build. | |
| * Fixed the logging output. Now, more logging information is displayed in the production build. |
CHANGELOG.md Outdated
| * Fixed the CMakeLists file. | ||
| * Fix to show more log info in prod build. | ||
| * Censored credentials in debug log messages. | ||
| * Fixed the rapidjson include directory. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fixed the rapidjson include directory. | |
| * Fixed the `rapidjson` include directory. |
CHANGELOG.md Outdated
| * Used custom token endpoint url from credentials. | ||
| | ||
| **olp-cpp-sdk-dataservice-read** | ||
| * Changed the GetPartitions API. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Changed the GetPartitions API. | |
| * Changed the `GetPartitions` API. |
Contributor Author
It will not be equal to git log, because there will be changes in text. The list of changes is received from: v1.16.0...master |
Smartkras force-pushed the release_1_17_0 branch from 3cfe3c6 to 0012b49 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #1437 +/- ## ======================================= Coverage 80.04% 80.04% ======================================= Files 340 340 Lines 13215 13215 Branches 1417 1417 ======================================= Hits 10577 10577 Misses 2065 2065 Partials 573 573 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomekpapiernik suggested changes Oct 10, 2023
CHANGELOG.md Outdated
| **Common** | ||
| * Improved support of HTTP proxy on iOS. | ||
| * Cleaned up DNS cache on error in cURL (Android). | ||
| * Fix the olp-cpp-sdk-core/CMakeLists.txt to include the externals include directory. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fix the olp-cpp-sdk-core/CMakeLists.txt to include the externals include directory. | |
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` file to include the externals include directory. |
CHANGELOG.md Outdated
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `PendingUrlRequests`. | ||
| * Added the `CallApiStream` to `olp::client::OlpClient` API. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in olp-cpp-sdk-core/CMakeLists.txt. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Fixed the `boost` and `rapidjson` includes path resolution in olp-cpp-sdk-core/CMakeLists.txt. | |
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. |
As this is a file (path) I think it should be formatted as code.
CHANGELOG.md Outdated
| * Fixed the `rapidjson` include directory. | ||
| | ||
| **olp-cpp-sdk-authentication** | ||
| * Added ability to use custom token endpoint URL from credentials in `Settings`. |
Contributor
There was a problem hiding this comment.
This is unclear. Does this mean that in Settings you can now use a custom URL; that URL comes from credentials?
Contributor Author
There was a problem hiding this comment.
Settings receives credentials in it's constructor, but token endpoint URL from that credentials was not used:
58f9566
Contributor
There was a problem hiding this comment.
@tomekpapiernik Credentials file may contain this URL, and after the file is parsed this URL will be used as a token provider URL. E.g. "here.token.endpoint.url=https://myurl.com/auth"
CHANGELOG.md Outdated
| * Fix the olp-cpp-sdk-core/CMakeLists.txt to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `PendingUrlRequests`. | ||
| * Added the `CallApiStream` to `olp::client::OlpClient` API. |
Contributor
There was a problem hiding this comment.
When you write the SOMETHING you should specify what that something is. In this case you'd say
the CallApiStream THING.
If you don't want to call out what CallApiStream is, remove "the".
Contributor
There was a problem hiding this comment.
Please explain in one sentence what this API for
CHANGELOG.md Outdated
| * Added ability to use custom token endpoint URL from credentials in `Settings`. | ||
| | ||
| **olp-cpp-sdk-dataservice-read** | ||
| * Added the `repository::GetPartitionsExtendedResponse` to support requests with more than 100 partitions in `GetPartitions` API. |
Contributor
There was a problem hiding this comment.
See the CallApiStream comment.
Smartkras force-pushed the release_1_17_0 branch from 0012b49 to 259144e Compare CHANGELOG.md Outdated
| * Fix the olp-cpp-sdk-core/CMakeLists.txt to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `PendingUrlRequests`. | ||
| * Added the `CallApiStream` to `olp::client::OlpClient` API. |
Contributor
There was a problem hiding this comment.
Please explain in one sentence what this API for
CHANGELOG.md Outdated
| * Cleaned up DNS cache on error in cURL (Android). | ||
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `PendingUrlRequests`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Improved logging in `PendingUrlRequests`. | |
| * Improved logging in `olp::client::PendingUrlRequests`. |
CHANGELOG.md Outdated
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `PendingUrlRequests`. | ||
| * Added `CallApiStream` to `olp::client::OlpClient` API. |
Contributor
There was a problem hiding this comment.
Please explain in one sentence what this API for
CHANGELOG.md Outdated
| * Improved logging in `PendingUrlRequests`. | ||
| * Added `CallApiStream` to `olp::client::OlpClient` API. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Fixed the logging output. Now, more logging information is displayed in the production build. |
Contributor
There was a problem hiding this comment.
If I understand it correctly this one is about just bumping the level from DEBUG to WARNING, and not about production builds
CHANGELOG.md Outdated
| * Added `CallApiStream` to `olp::client::OlpClient` API. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Fixed the logging output. Now, more logging information is displayed in the production build. | ||
| * Censored credentials in debug log messages for the network logs on `DEBUG` log level. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Censored credentials in debug log messages for the network logs on `DEBUG` log level. | |
| * Censored credentials in log messages for the network logs on `DEBUG` log level. |
CHANGELOG.md Outdated
| * Fixed the `rapidjson` include directory. | ||
| | ||
| **olp-cpp-sdk-authentication** | ||
| * Added ability to use custom token endpoint URL from credentials in `Settings`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added ability to use custom token endpoint URL from credentials in `Settings`. | |
| * Added ability to use custom token endpoint URL from credentials in `olp::authentication::Settings`. |
CHANGELOG.md Outdated
| * Fixed the `rapidjson` include directory. | ||
| | ||
| **olp-cpp-sdk-authentication** | ||
| * Added ability to use custom token endpoint URL from credentials in `Settings`. |
Contributor
There was a problem hiding this comment.
@tomekpapiernik Credentials file may contain this URL, and after the file is parsed this URL will be used as a token provider URL. E.g. "here.token.endpoint.url=https://myurl.com/auth"
CHANGELOG.md Outdated
| * Added ability to use custom token endpoint URL from credentials in `Settings`. | ||
| | ||
| **olp-cpp-sdk-dataservice-read** | ||
| * Added `repository::GetPartitionsExtendedResponse` to support requests with more than 100 partitions in `GetPartitions` API. |
Contributor
There was a problem hiding this comment.
Is this in olp::dataservice::read::VersionedLayerClient? Add it, as it is not clear what GetParitions API
CHANGELOG.md Outdated
| | ||
| **olp-cpp-sdk-dataservice-read** | ||
| * Added `repository::GetPartitionsExtendedResponse` to support requests with more than 100 partitions in `GetPartitions` API. | ||
| * Fix the incorrect parse error condition in `PartitionsRepository::ParsePartitionsStream`. |
Contributor
There was a problem hiding this comment.
Again: streaming was not released - this change is not what changed from the latest release
Smartkras force-pushed the release_1_17_0 branch from 259144e to c97e525 Compare Smartkras force-pushed the release_1_17_0 branch from c97e525 to 4007960 Compare CHANGELOG.md Outdated
| * Added default copy and move constructors and copy and move operators to `model` namespace classes. | ||
| | ||
| **olp-cpp-sdk-dataservice-write** | ||
| * Added default copy and move constructors and copy and move operators to `model` namespace classes. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added default copy and move constructors and copy and move operators to `model` namespace classes. | |
| * Added default copy and move constructors and operators to the `model` namespace classes. |
CHANGELOG.md Outdated
Comment on lines 20 to 21
| * Added support for requests with more than 100 partitions in `olp::dataservice::read::repository::PartitionsRepository` API. | ||
| * Added default copy and move constructors and copy and move operators to `model` namespace classes. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added support for requests with more than 100 partitions in `olp::dataservice::read::repository::PartitionsRepository` API. | |
| * Added default copy and move constructors and copy and move operators to `model` namespace classes. | |
| * Added support for requests with more than 100 partitions in the `olp::dataservice::read::repository::PartitionsRepository` API. | |
| * Added default copy and move constructors and operators to the `model` namespace classes. |
CHANGELOG.md Outdated
| * Fixed the `rapidjson` include directory. | ||
| | ||
| **olp-cpp-sdk-authentication** | ||
| * Added ability to use custom token endpoint URL from credentials in `olp::authentication::Settings`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added ability to use custom token endpoint URL from credentials in `olp::authentication::Settings`. | |
| * Added the ability to use a custom token endpoint URL from credentials in `olp::authentication::Settings`. |
CHANGELOG.md Outdated
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed log level to `WARNING` for error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. | ||
| * Add status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. | ||
| * Censored credentials in log messages for the network logs on `DEBUG` log level. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Censored credentials in log messages for the network logs on `DEBUG` log level. | |
| * Censored credentials in log messages for the network logs on the `DEBUG` log level. |
CHANGELOG.md Outdated
| * Added `CallApiStream` to `olp::client::OlpClient` API, which is using a `SAX` parser and a `JSON` byte stream to parse the layer partitions while they are downloading. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed log level to `WARNING` for error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. | ||
| * Add status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Add status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. | |
| * Added a status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. |
CHANGELOG.md Outdated
| * Improved logging in `olp::client::PendingUrlRequests`. | ||
| * Added `CallApiStream` to `olp::client::OlpClient` API, which is using a `SAX` parser and a `JSON` byte stream to parse the layer partitions while they are downloading. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed log level to `WARNING` for error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Changed log level to `WARNING` for error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. | |
| * Changed the log level to `WARNING` in the error message that is returned when the maximum number of `HTTP` requests is reached in `olp::http::SendOutcome OLPNetworkIOS`. |
Contributor Author
There was a problem hiding this comment.
Log level is the way the message is shown, not something in the message.
CHANGELOG.md Outdated
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | ||
| * Improved logging in `olp::client::PendingUrlRequests`. | ||
| * Added `CallApiStream` to `olp::client::OlpClient` API, which is using a `SAX` parser and a `JSON` byte stream to parse the layer partitions while they are downloading. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added `CallApiStream` to `olp::client::OlpClient` API, which is using a `SAX` parser and a `JSON` byte stream to parse the layer partitions while they are downloading. | |
| * Added `CallApiStream` to the `olp::client::OlpClient` API that uses the `SAX` parser and `JSON` byte stream to parse the layer partitions while they are downloading. |
CHANGELOG.md Outdated
| * Improved support of HTTP proxy on iOS. | ||
| * Cleaned up DNS cache on error in cURL (Android). | ||
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. | ||
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added the possibility to specify DNS using `WithDNSServers` to `olp::http::NetworkSettings` API. | |
| * Added the possibility to specify DNS using `WithDNSServers` to the `olp::http::NetworkSettings` API. |
Smartkras force-pushed the release_1_17_0 branch from 4007960 to f575c4d Compare CHANGELOG.md Outdated
| @@ -1,3 +1,28 @@ | |||
| ## v1.17.0 (09/10/2023) | |||
CHANGELOG.md Outdated
| * Improved logging in `olp::client::PendingUrlRequests`. | ||
| * Added `CallApiStream` to the `olp::client::OlpClient` API that uses the `SAX` parser and `JSON` byte stream to parse the layer partitions while they are downloading. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::SendOutcome OLPNetworkIOS`. | |
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::OLPNetworkIOS::Send`. |
Smartkras force-pushed the release_1_17_0 branch from f575c4d to a50e9c3 Compare 
andrey-kashcheev previously approved these changes Oct 11, 2023
CHANGELOG.md Outdated
| * Improved logging in `olp::client::PendingUrlRequests`. | ||
| * Added `CallApiStream` to the `olp::client::OlpClient` API that uses the `SAX` parser and `JSON` byte stream to parse the layer partitions while they are downloading. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::OLPNetworkIOS::Send`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::OLPNetworkIOS::Send`. | |
| * Changed the log level to `WARNING` for the error message when the max number of `HTTP` requests has been reached in `olp::http::OLPNetworkIOS::Send`. |
CHANGELOG.md Outdated
| * Added `CallApiStream` to the `olp::client::OlpClient` API that uses the `SAX` parser and `JSON` byte stream to parse the layer partitions while they are downloading. | ||
| * Fixed the `boost` and `rapidjson` includes path resolution in `olp-cpp-sdk-core/CMakeLists.txt`. | ||
| * Changed the log level to `WARNING` for the error message when max number of `HTTP` requests has been reached in `olp::http::OLPNetworkIOS::Send`. | ||
| * Add a status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Add a status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. | |
| * Added a status code for failed `HTTP` requests in `olp::dataservice::read::repository::PrefetchTilesRepository`. |
CHANGELOG.md Outdated
| * Added the ability to use a custom token endpoint URL from credentials in `olp::authentication::Settings`. | ||
| | ||
| **olp-cpp-sdk-dataservice-read** | ||
| * Added support for requests with more than 100 partitions in the `olp::dataservice::read::repository::PartitionsRepository` API. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added support for requests with more than 100 partitions in the `olp::dataservice::read::repository::PartitionsRepository` API. | |
| * Added support of requests with more than 100 partitions in the `olp::dataservice::read::repository::PartitionsRepository` API. |
Smartkras force-pushed the release_1_17_0 branch from a50e9c3 to d418e2e Compare CHANGELOG.md Outdated
| **Common** | ||
| * Improved support of HTTP proxy on iOS. | ||
| * Cleaned up DNS cache on error in cURL (Android). | ||
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Updated the `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. | |
| * Updated `olp-cpp-sdk-core/CMakeLists.txt` to include the externals include directory. |
CHANGELOG.md Outdated
Comment on lines 21 to 24
| * Added default copy and move constructors and copy and move operators to the `model` namespace classes. | ||
| | ||
| **olp-cpp-sdk-dataservice-write** | ||
| * Added default copy and move constructors and copy and move operators to the `model` namespace classes. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added default copy and move constructors and copy and move operators to the `model` namespace classes. | |
| **olp-cpp-sdk-dataservice-write** | |
| * Added default copy and move constructors and copy and move operators to the `model` namespace classes. | |
| * Added default copy and move constructors and operators to the `model` namespace classes. | |
| **olp-cpp-sdk-dataservice-write** | |
| * Added default copy and move constructors and operators to the `model` namespace classes. |
Updated CHANGELOG and CMakeLists files for the release v1.17.0 Relates-To: OLPEDGE-2835 Signed-off-by: Yevhen Krasilnyk <ext-yevhen.krasilnyk@here.com>
Smartkras force-pushed the release_1_17_0 branch from d418e2e to 41e9c1e Compare HalynaDumych approved these changes Oct 11, 2023
andrey-kashcheev approved these changes Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updated CHANGELOG and CMakeLists files for the release v1.17.0
Relates-To: OLPEDGE-2835