This repository was archived by the owner on Oct 3, 2020. It is now read-only.
IPv6 addres parsing in KubeConfig.from_service_account#50
Merged
hjacobs merged 2 commits intohjacobs:masterfrom Dec 23, 2019
Merged
IPv6 addres parsing in KubeConfig.from_service_account#50hjacobs merged 2 commits intohjacobs:masterfrom
hjacobs merged 2 commits intohjacobs:masterfrom
Conversation
hjacobs reviewed Dec 23, 2019
Owner
| Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when KUBERNETES_SERVICE_HOST/PYKUBE_KUBERNETES_SERVICE_PORT is set to IPv6 address then server url is calculated incorrectly. So I added IPv6 address bracketing the same way it is done in official Kubernetes Python client