Open
Conversation
Collaborator
| Is it possible to review and merge this PR for the upcoming release? |
v-ein reviewed Jan 31, 2024
| return; | ||
| PyDict_SetItemString(outDict, "items", mvPyObject(ToPyList(inConfig.names))); | ||
| PyDict_SetItemString(outDict, "num_items", mvPyObject(ToPyInt(inConfig.itemsHeight))); | ||
| PyDict_SetItemString(outDict, "index", mvPyObject(ToPyBool(inConfig.sendindex))); |
Collaborator
There was a problem hiding this comment.
In the parser, the parameter is named "index_items". Here, its name is "index". Oops.
v-ein reviewed Jan 31, 2024
| args.push_back({ mvPyDataType::StringList, "items", mvArgType::POSITIONAL_ARG, "()", "A tuple of items to be shown in the listbox. Can consist of any combination of types. All items will be displayed as strings." }); | ||
| args.push_back({ mvPyDataType::String, "default_value", mvArgType::KEYWORD_ARG, "''", "String value of the item that will be selected by default." }); | ||
| args.push_back({ mvPyDataType::Integer, "num_items", mvArgType::KEYWORD_ARG, "3", "Expands the height of the listbox to show specified number of items." }); | ||
| args.push_back({ mvPyDataType::Bool, "index_items", mvArgType::KEYWORD_ARG, "False", "Set the user_data to the index of the clicked item and not the item itself" }); |
Collaborator
There was a problem hiding this comment.
The description says the index would be in user_data, but the code actually puts it to app_data. The description needs to be corrected.
v-ein reviewed Jan 31, 2024
| config.disabled_value = config.names[config.index]; | ||
| auto value = *config.value; | ||
| if (config.sendindex) { | ||
| *config.value = std::to_string(config.index); |
Collaborator
There was a problem hiding this comment.
I don't really like the idea of converting the index to a string here. I think mvListbox::getPyValue() should handle it and return a string if index_items is False, and a number (the index) if it's True. The same for the callback: instead of converting the index to a string, it should call ToPyInt and return an integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Add options to listbox data
assignees: @hoffstadt
Closes #1236
Description:
Adding a new parameter to the Listbox; index_items when this parameter is set instead of giving the "item of the listbox" inside the user_data parameter the index of the item will be given.
Concerning Areas: