Conversation
neonphog left a comment
neonphog left a comment There was a problem hiding this comment.
Just putting a reject on here to make sure it doesn't get merged before the git references in Cargo.tomls get set to real published versions - feel free to clear this when ready.
crates/core/src/agent/chain_store.rs Outdated
| use holochain_persistence_api::{ | ||
| error::PersistenceResult, | ||
| txn::{CursorDyn, CursorProviderDyn}, | ||
| }; |
There was a problem hiding this comment.
prefer uses at top of file or within a scope
| self.holding_map == other.holding_map | ||
| && (*content.read().unwrap()).get_id() == (*other_content.read().unwrap()).get_id() | ||
| && *meta.read().unwrap() == *other_meta.read().unwrap() | ||
| && (*self.persistence_manager).get_id() == (*other.persistence_manager).get_id() |
There was a problem hiding this comment.
I saw another Eq operation like this with the derefs / get_id() thing - should this be a PartialEq/Eq on the persistence_manager itself?
There was a problem hiding this comment.
Agreed that this could be a partialEQ on the Persistence Manager itself
crates/core/src/dht/dht_store.rs Outdated
| )) | ||
| } | ||
| | ||
| use holochain_persistence_api::txn::{CursorDyn, CursorProviderDyn}; |
| do | ||
| cd $d | ||
| if grep "$CRATE" Cargo.toml > /dev/null; then | ||
| cargo-add add $CRATE --git $REPO --branch $BRANCH |
neonphog left a comment
neonphog left a comment There was a problem hiding this comment.
A lot of the code is easier to read/comprehend - nice work 👍
struktured changed the title 
lucksus left a comment
lucksus left a comment There was a problem hiding this comment.
👏 👏 👏
(+1 on cleaning up the dependencies after merging the remote branch)
4 participants
PR summary
This PR integrates the latest api changes/improvements from this holochain- persistence PR. The PR needs to be merged and release on crates.io BEFORE this PR is merged. Summary of changes:
PersistenceManagertrait which wraps a single CAS, EAV, and transactional cursor api.CursorRwto mutate the CAS and EAV in a transactional capacity in the persister and reducers.Attributeimplementation as it's provided by persistence api now.testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation