Skip to content

Re-write Timer class #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2021
Merged

Re-write Timer class #15

merged 1 commit into from
Oct 3, 2021

Conversation

@htmlboss
Copy link
Owner

@htmlboss htmlboss commented Oct 2, 2021 •
edited
Loading

Re-write Timer class to fire a user-defined callback function at a regular user-defined interval (i.e. make Timer generic and thus more reusable).

  • Also extracted the notion of frame time from the class since that's really more of an Engine concern.
@htmlboss htmlboss self-assigned this Oct 2, 2021
htmlboss
htmlboss commented Oct 3, 2021
View reviewed changes
MP-APS/Timer.h
public:
Timer() noexcept;

Timer(const double secondsBetweenCallbackTriggers, TimerCallbackFunc callback)
Copy link
Owner Author

@htmlboss htmlboss Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimerCallbackFunc is passed by value for performance reasons since we're storing it https://stackoverflow.com/a/18366273/2231969
@htmlboss htmlboss merged commit 385f966 into master Oct 3, 2021
@htmlboss htmlboss deleted the improve-timer-class branch October 3, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement

1 participant

@htmlboss