<issue> : Fix handling of Content-Type headers with additional parameters #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request fixes an issue in bodyDecoder-middleware.js where the server incorrectly handled Content-Type headers containing additional parameters, such as charset=utf-8. The previous implementation used strict string comparisons, which caused issues when headers like application/json; charset=utf-8 or application/x-www-form-urlencoded; charset=utf-8 were received.
Changes:
Replaced strict equality checks with startsWith() to handle Content-Type headers that include additional properties.
Now the server can process requests with headers like application/json; charset=utf-8 and application/x-www-form-urlencoded; charset=utf-8.