Add CIMD support for automatic oauth app creation, and PKCE support#1978
Merged
coyotte508 merged 4 commits intomainfrom Nov 21, 2025
Merged
Add CIMD support for automatic oauth app creation, and PKCE support#1978coyotte508 merged 4 commits intomainfrom
coyotte508 merged 4 commits intomainfrom
Conversation
coyotte508 commented Nov 7, 2025
Member Author
There was a problem hiding this comment.
instead of forwarding url everywhere, we could use contextStore like here: https://github.com/huggingface/Mongoku/blob/2a6c715c5bf4a7f7351aa3b3ce90ecd857e61d70/src/hooks.server.ts#L17-L48
(not sure for compat with non-node runtimes)
could also be used for structued logs (eg request id, ...)
rtrompier approved these changes Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CIMD support, for automatic oauth app creation, and add PKCE support
Just need to set
OPENID_CLIENT_ID=__CIMD__orOPENID_CONFIG={CLIENT_ID:"__CIMD__",...}By the way after this PR, no need for
OPENID_CLIENT_SECRET, so open id config can be a public var and does not need to be secret (just remove the secret from it), cc @rtrompierInternal ref: https://github.com/huggingface-internal/moon-landing/pull/15624
Tested on https://huggingface.co/spaces/coyotte508/chat-ui - first real use of CIMD cc @evalstate :)
Note
hfChat-codeVerifier(lasts 1 hour) during oauth process/${base}instead of"/"... (too late to change it?)