Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Refactor hyperd daemon package #445

Merged
merged 8 commits into from
Dec 6, 2016
Merged

Refactor hyperd daemon package #445

merged 8 commits into from
Dec 6, 2016

Conversation

@gnawux
Copy link
Member

@gnawux gnawux commented Nov 3, 2016

  • move all the pod management procedures from runv to hyperd
  • make the structures easier to maintain

//WIP, could not merge yet.
@gnawux
Copy link
Member Author

gnawux commented Nov 3, 2016 •
edited
Loading

Still have something to fix, including

  • info
  • service update
  • build
  • vbox graph driver (should we disable it now?)

and will rebase to current master after the fix
@gnawux
Copy link
Member Author

gnawux commented Nov 5, 2016 •
edited
Loading

All the major parts have been done. now

  • fix build
  • rebase to current master
  • test
@gnawux gnawux force-pushed the refactor_core branch 2 times, most recently from 17c766c to fe91567 Compare November 17, 2016 15:45
@gnawux
Copy link
Member Author

gnawux commented Nov 17, 2016

rebased to master ( #447 ), however, still lot of things to be fixed
@gnawux
Copy link
Member Author

gnawux commented Nov 18, 2016

fixed the build, but still need to correct the behaviors.
@gnawux
Copy link
Member Author

gnawux commented Nov 19, 2016 

OOPS: 9 passed, 1 skipped, 8 FAILED --- FAIL: Test (74.55s)

no panic at least, better than 0 passed.

go on
@gnawux
Copy link
Member Author

gnawux commented Nov 21, 2016

OOPS: 11 passed, 1 skipped, 6 FAILED

two more passed
@gnawux
Copy link
Member Author

gnawux commented Nov 21, 2016 •
edited
Loading

OOPS: 13 passed, 1 skipped, 4 FAILED

two more again.

  • PASS: hyper_test.go:256: TestSuite.TestAddListDeleteService 24.350s
  • PASS: hyper_test.go:125: TestSuite.TestCreateAndStartPod 17.858s
  • FAIL: hyper_test.go:168: TestSuite.TestCreateContainer
  • PASS: hyper_test.go:56: TestSuite.TestGetContainerInfo 0.003s
  • PASS: hyper_test.go:44: TestSuite.TestGetContainerList 0.001s
  • PASS: hyper_test.go:70: TestSuite.TestGetContainerLogs 0.001s
  • PASS: hyper_test.go:50: TestSuite.TestGetImageList 0.002s
  • PASS: hyper_test.go:111: TestSuite.TestGetPodInfo 0.001s
  • PASS: hyper_test.go:32: TestSuite.TestGetPodList 0.000s
  • PASS: hyper_test.go:38: TestSuite.TestGetVMList 0.000s
  • PASS: hyper_test.go:417: TestSuite.TestPauseAndUnpausePod 7.729s
  • PASS: hyper_test.go:491: TestSuite.TestPing 0.000s
  • PASS: hyper_test.go:84: TestSuite.TestPostAttach 11.977s
  • PASS: hyper_test.go:222: TestSuite.TestPullImage 45.522s
  • FAIL: hyper_test.go:191: TestSuite.TestRenameContainer
  • FAIL: hyper_test.go:389: TestSuite.TestSetPodLabels
  • FAIL: hyper_test.go:357: TestSuite.TestStartAndStopPod
@gnawux gnawux force-pushed the refactor_core branch 2 times, most recently from 1c7c921 to 0808092 Compare November 21, 2016 16:44
@gnawux
Copy link
Member Author

gnawux commented Nov 21, 2016 •
edited
Loading

OOPS: 15 passed, 1 skipped, 2 FAILED

  • PASS: hyper_test.go:256: TestSuite.TestAddListDeleteService 24.350s
  • PASS: hyper_test.go:125: TestSuite.TestCreateAndStartPod 17.858s
  • PASS: hyper_test.go:168: TestSuite.TestCreateContainer 14.071s
  • PASS: hyper_test.go:56: TestSuite.TestGetContainerInfo 0.003s
  • PASS: hyper_test.go:44: TestSuite.TestGetContainerList 0.001s
  • PASS: hyper_test.go:70: TestSuite.TestGetContainerLogs 0.001s
  • PASS: hyper_test.go:50: TestSuite.TestGetImageList 0.002s
  • PASS: hyper_test.go:111: TestSuite.TestGetPodInfo 0.001s
  • PASS: hyper_test.go:32: TestSuite.TestGetPodList 0.000s
  • PASS: hyper_test.go:38: TestSuite.TestGetVMList 0.000s
  • PASS: hyper_test.go:417: TestSuite.TestPauseAndUnpausePod 7.729s
  • PASS: hyper_test.go:491: TestSuite.TestPing 0.000s
  • PASS: hyper_test.go:84: TestSuite.TestPostAttach 11.977s
  • PASS: hyper_test.go:222: TestSuite.TestPullImage 45.522s
  • FAIL: hyper_test.go:191: TestSuite.TestRenameContainer
  • PASS: hyper_test.go:389: TestSuite.TestSetPodLabels 7.335s
  • FAIL: hyper_test.go:357: TestSuite.TestStartAndStopPod
@gnawux
Copy link
Member Author

gnawux commented Nov 21, 2016 •
edited
Loading

rename container is fixed

  • PASS: hyper_test.go:256: TestSuite.TestAddListDeleteService 24.350s
  • PASS: hyper_test.go:125: TestSuite.TestCreateAndStartPod 17.858s
  • PASS: hyper_test.go:168: TestSuite.TestCreateContainer 14.071s
  • PASS: hyper_test.go:56: TestSuite.TestGetContainerInfo 0.003s
  • PASS: hyper_test.go:44: TestSuite.TestGetContainerList 0.001s
  • PASS: hyper_test.go:70: TestSuite.TestGetContainerLogs 0.001s
  • PASS: hyper_test.go:50: TestSuite.TestGetImageList 0.002s
  • PASS: hyper_test.go:111: TestSuite.TestGetPodInfo 0.001s
  • PASS: hyper_test.go:32: TestSuite.TestGetPodList 0.000s
  • PASS: hyper_test.go:38: TestSuite.TestGetVMList 0.000s
  • PASS: hyper_test.go:417: TestSuite.TestPauseAndUnpausePod 7.729s
  • PASS: hyper_test.go:491: TestSuite.TestPing 0.000s
  • PASS: hyper_test.go:84: TestSuite.TestPostAttach 11.977s
  • PASS: hyper_test.go:222: TestSuite.TestPullImage 45.522s
  • PASS: hyper_test.go:191: TestSuite.TestRenameContainer 14.601s
  • PASS: hyper_test.go:389: TestSuite.TestSetPodLabels 7.335s
  • FAIL: hyper_test.go:357: TestSuite.TestStartAndStopPod
@xiaods
Copy link
Contributor

xiaods commented Nov 22, 2016

Cool
@gnawux
Copy link
Member Author

gnawux commented Nov 22, 2016 •
edited
Loading 

--- PASS: Test (116.71s) PASS ok github.com/hyperhq/hyperd/integration 116.720s

There are still lots of issues to fix, however, at least the integration cases are passed. Cheers and go on.
@gnawux
Copy link
Member Author

gnawux commented Nov 23, 2016 •
edited
Loading 

The log length has exceeded the limit of 4 MB The job has been terminated

...
@gnawux
Copy link
Member Author

gnawux commented Nov 23, 2016 

+++ [1122 23:39:27] TEST PASSED +++ [1122 23:39:27] Clean up complete

Passed one round, still need fix the save/re-load issues
@gnawux
Copy link
Member Author

gnawux commented Nov 25, 2016

WOW! It is the first time this branch pass the test in the past 5 months.

There are still lot of known issues to be solved, however, it has never been so close to be completed.
@feiskyer feiskyer mentioned this pull request Nov 30, 2016
Closed
31 tasks
@gnawux
Copy link
Member Author

gnawux commented Dec 4, 2016

Added save/load to/from leveldb
gnawux added 3 commits December 5, 2016 22:21
@gnawux
[refactor] update daemon logic based on the pod modification
0188824 
Signed-off-by: Wang Xu <gnawux@gmail.com>
@gnawux
[refactor] update the client/server based on the refactor
98f2610 
Signed-off-by: Wang Xu <gnawux@gmail.com>
@gnawux
[refactor] update the build tool chain and test cases for refactor
dbe97ba 
Signed-off-by: Wang Xu <gnawux@gmail.com>
@gnawux
Copy link
Member Author

gnawux commented Dec 5, 2016

Squashed the commits. Same contents with the previous commits. And the old commits are kept here.
@gnawux gnawux mentioned this pull request Dec 5, 2016
Open
14 tasks
@gnawux gnawux changed the title [WIP] Refactor hyperd daemon package Refactor hyperd daemon package Dec 5, 2016
@gnawux
Copy link
Member Author

gnawux commented Dec 5, 2016

I listed remain tasks in #462 , and we may merge this and keep working on fix all issues.
@gnawux
[refactor] update related runV godep and introduce hlog
034cb40 
Signed-off-by: Wang Xu <gnawux@gmail.com>
@feiskyer
Copy link
Contributor

feiskyer commented Dec 6, 2016

Cool. LGTM.
@feiskyer feiskyer merged commit 19db400 into hyperhq:master Dec 6, 2016
@gnawux gnawux mentioned this pull request Dec 7, 2016
Merged
@gnawux gnawux added this to the v0.8.0 milestone Mar 20, 2017
@gnawux gnawux mentioned this pull request Mar 20, 2017
Closed
@gnawux gnawux deleted the refactor_core branch April 7, 2017 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@gnawux @xiaods @feiskyer