Use new methods for parsing with uninitialized headers from httparse #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seanmonstar reviewed Aug 11, 2021
src/proto/h1/role.rs Outdated
| @@ -1,9 +1,7 @@ | |||
| // `mem::uninitialized` replaced with `mem::MaybeUninit`, | |||
| // can't upgrade yet | |||
| #![allow(deprecated)] | |||
Member
There was a problem hiding this comment.
Suggested change
| #![allow(deprecated)] |
Member
| Alright, I've released |
Contributor Author
|
|
Contributor Author
| How am I supposed to change commit messages now? |
Member
| Don't worry about the commit messages, I can adjust it when squashing/merging. |
seanmonstar approved these changes Aug 19, 2021
This was referenced Mar 27, 2022
This was referenced Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This patch fixes #2532
It uses methods implemented
in this PRin this PR, so CI might fail before it gets merged