Match default export of plugin and plugin object of flat configs #3213
+42 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
soren121 force-pushed the add-default-export branch 2 times, most recently from cbc3a9c to 6cc837a Compare 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #3213 +/- ## =========================================== + Coverage 82.25% 95.77% +13.51% =========================================== Files 94 83 -11 Lines 4283 3691 -592 Branches 1478 1332 -146 =========================================== + Hits 3523 3535 +12 + Misses 760 156 -604 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soren121 changed the title plugin object of flat configs 
soren121 force-pushed the add-default-export branch from 78885fa to 12d770c Compare soren121 changed the title plugin object of flat configsplugin object of flat configs 
| Is there a way to progress with this PR? It blocks usage of default configs with flat structure. |
| cc @ljharb |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #3212
The plugin's default export is not equal by reference to the
pluginobject defined on flat configs. This can cause issues for ESLint's plugin normalization in some scenarios. This PR changes the default export to equal thepluginobject.I've added tests for this change, and I also added missing tests for the flat config exports.