This repository was archived by the owner on Jan 3, 2023. It is now read-only.
ISSDEV-3990: Deleted deprecated samples #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| We cannot delete samples as soon as we deprecate them. Besides, the idea is to remove the sample.json file so that they won't get pulled in the IDE, rather than removing the sources entirely. |
Collaborator
| @Propanu The plan was to remove samples in ISS 2020 and putting the deprecation notice in ISS 2019 Update 4. |
Contributor
| Yes, I failed to realize this only affects the 2020 branch this morning. LGTM! |
Propanu approved these changes Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.